Change the location of CatalogSource with Kuadrant #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@azgabur Hi, what's the progress on this? We can merge the catalog source change, but I don't see why keycloak change may be required. Is it fine with you? |
|
Hey. Yes the catalogSource location change can be merged. I decided to do the admin credentials secret management differently so I will remove that commit. 👍 |
Signed-off-by: Alex Zgabur <[email protected]>
azgabur
force-pushed
the
rhbk_refactor
branch
from
6ea72cb to
7ad0ef8
Compare
averevki
changed the title
averevki
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOW PRIORITY
In the helm deployment of Kuadrant, the secret containing login credentials to Keycloack is located under different name and key.
To verify run some keycloack test on cluster witch has Kuadrant deployed with Helm:
Additionally the location of CatalogSource containing information about Kuadrant version has been moved 6ea72cb reflects that now.